curl fall back to wget#22
Open
baylanger wants to merge 1 commit into
Open
Conversation
The implement of curl on Synology NAS is currently breaking up this script. This PR adds to the config which download app (curl or wget) to use based on a file that is specific to Synology. That said, the very first version I had made was adding a "curl check" and if it failed, then it would fall back to wget. Somehow I think this solution is still better since it can handle other odd curl on NAS or other Linux distribution. Let me know what you think. Note: it's not possible to completely silence wget with arguments. At least not on Synology unless using a redirect aka 2>/dev/null
Owner
|
Thanks for your PR, I'll take a look at it calmly because I don't agree with Adrian Kumpf's latest move with Teslamate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current use of "curl" in this script breaks on Synology NAS.
This PR adds to the config which download app (curl or wget) to use based on a file that is specific to Synology.
That said, the very first version I had made was adding a "curl check" and if it failed, then it would fall back to wget. Somehow I think this solution is still better since it can handle other odd curl on NAS or other Linux distribution.
Let me know what you think.
Note: it's not possible to completely silence wget with arguments. At least not on Synology unless using a redirect aka 2>/dev/null